Fix code actions (and code actions integration tests) #11141
Merged
+356
−384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were running most of them twice. Very confusing when you expect one test failure, but get two.
davidwengier
added a commit
to davidwengier/razor
that referenced
this pull request
Nov 4, 2024
Merged
alexgav
reviewed
Nov 4, 2024
|
|
||
| namespace Microsoft.AspNetCore.Razor.LanguageServer.CodeActions; | ||
|
|
||
| public abstract class CodeActionEndToEndTestBase(ITestOutputHelper testOutput) : SingleServerDelegatingEndpointTestBase(testOutput) |
There was a problem hiding this comment.
I did mention that we weren't consistent, and one of the ways we're not is that in product code we mostly use AbstractXXX and in tests we use XXXBase. I have no idea how we came to this state, and I am not trying to pick a side, but this naming convention seemed to fit best with where the change is.
davidwengier
added a commit
that referenced
this pull request
Nov 7, 2024
Fixes #10742 Needs dotnet/roslyn#75711 before it will build Also will need to merge in main once #11141 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My bad. In #11135 I failed to notice that the
GenerateRazorCodeActionContextAsyncalso modified the original code actions request, to handle an oddity of VS LSP, where it sends the users selected range (or cursor position) as a different property, and uses theRangeproperty as the whole line.